Skip to content

fix: integration fixes running in k8s - #7

Merged
soluwalana merged 5 commits into
nmp/customizerfrom
solu/integration-testing
Aug 6, 2026
Merged

fix: integration fixes running in k8s#7
soluwalana merged 5 commits into
nmp/customizerfrom
solu/integration-testing

Conversation

@soluwalana

Copy link
Copy Markdown
Owner

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Issues

List issues that this PR closes (syntax):

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you run the unit tests and functional tests locally? Visit our Testing Guide for how to run tests
  • Did you add or update any necessary documentation? Visit our Document Development Guide for how to write, build and test the docs.

Additional Information

  • ...

@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown

❌ Submodule Fast-Forward Check Failed

Check based on commit: 9a11560 (PR #7 from solu/integration-testing)

❌ Submodules that need attention:

Gym: ❌ PR branch is BEHIND nmp/customizer branch
TARGET (nmp/customizer branch): https://github.com/soluwalana/Gym/commits/c55600cac042a2c3081caaa0e2138630bbf21bf2/
CURRENT (PR #7 from solu/integration-testing): https://github.com/soluwalana/Gym/commits/84e6a6d71b6d8b4514d70cf4e9d7e4a0734e1eb7/

Please ensure all submodule commits are fast-forwards of the nmp/customizer branch before merging.

@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown

❌ Submodule Fast-Forward Check Failed

Check based on commit: 3aec7ad (PR #7 from solu/integration-testing)

❌ Submodules that need attention:

Gym: ❌ PR branch is BEHIND nmp/customizer branch
TARGET (nmp/customizer branch): https://github.com/soluwalana/Gym/commits/c55600cac042a2c3081caaa0e2138630bbf21bf2/
CURRENT (PR #7 from solu/integration-testing): https://github.com/soluwalana/Gym/commits/84e6a6d71b6d8b4514d70cf4e9d7e4a0734e1eb7/

Please ensure all submodule commits are fast-forwards of the nmp/customizer branch before merging.

@soluwalana
soluwalana force-pushed the solu/integration-testing branch from 3aec7ad to 5eb30ce Compare August 4, 2026 17:02
@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown

❌ Submodule Fast-Forward Check Failed

Check based on commit: 5eb30ce (PR #7 from solu/integration-testing)

❌ Submodules that need attention:

Gym: ❌ PR branch is BEHIND nmp/customizer branch
TARGET (nmp/customizer branch): https://github.com/soluwalana/Gym/commits/c55600cac042a2c3081caaa0e2138630bbf21bf2/
CURRENT (PR #7 from solu/integration-testing): https://github.com/soluwalana/Gym/commits/84e6a6d71b6d8b4514d70cf4e9d7e4a0734e1eb7/

Please ensure all submodule commits are fast-forwards of the nmp/customizer branch before merging.

@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown

❌ Submodule Fast-Forward Check Failed

Check based on commit: e3a3897 (PR #7 from solu/integration-testing)

❌ Submodules that need attention:

Gym: ❌ PR branch is BEHIND nmp/customizer branch
TARGET (nmp/customizer branch): https://github.com/soluwalana/Gym/commits/c55600cac042a2c3081caaa0e2138630bbf21bf2/
CURRENT (PR #7 from solu/integration-testing): https://github.com/soluwalana/Gym/commits/84e6a6d71b6d8b4514d70cf4e9d7e4a0734e1eb7/

Megatron-Bridge: ❌ PR branch is BEHIND nmp/customizer branch
TARGET (nmp/customizer branch): https://github.com/NVIDIA-NeMo/Megatron-Bridge/commits/573e088c9c6740082c39744e03dc5b009e730ed4/
CURRENT (PR #7 from solu/integration-testing): https://github.com/NVIDIA-NeMo/Megatron-Bridge/commits/a056408d29ad1070fb926512991075998c9e023f/

Please ensure all submodule commits are fast-forwards of the nmp/customizer branch before merging.

@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown

❌ Submodule Fast-Forward Check Failed

Check based on commit: b430330 (PR #7 from solu/integration-testing)

✅ Submodules that are properly updated:

Gym: ✅ PR branch is ahead of nmp/customizer branch (fast-forward)

❌ Submodules that need attention:

Megatron-Bridge: ❌ PR branch is BEHIND nmp/customizer branch
TARGET (nmp/customizer branch): https://github.com/NVIDIA-NeMo/Megatron-Bridge/commits/573e088c9c6740082c39744e03dc5b009e730ed4/
CURRENT (PR #7 from solu/integration-testing): https://github.com/NVIDIA-NeMo/Megatron-Bridge/commits/a056408d29ad1070fb926512991075998c9e023f/

Please ensure all submodule commits are fast-forwards of the nmp/customizer branch before merging.

@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown

✅ Submodule Fast-Forward Check Results

Check based on commit: b9a0fa5 (PR #7 from solu/integration-testing)

✅ Submodules that are properly updated:

Gym: ✅ PR branch is ahead of nmp/customizer branch (fast-forward)
Megatron-Bridge: ✅ PR branch is ahead of nmp/customizer branch (fast-forward)

All submodule changes look good! ✨

@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown

✅ Submodule Fast-Forward Check Results

Check based on commit: 16077bc (PR #7 from solu/integration-testing)

✅ Submodules that are properly updated:

Gym: ✅ PR branch is ahead of nmp/customizer branch (fast-forward)
Megatron-Bridge: ✅ PR branch is ahead of nmp/customizer branch (fast-forward)

All submodule changes look good! ✨

@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown

✅ Submodule Fast-Forward Check Results

Check based on commit: 32fe6ba (PR #7 from solu/integration-testing)

✅ Submodules that are properly updated:

Gym: ✅ PR branch is ahead of nmp/customizer branch (fast-forward)
Megatron-Bridge: ✅ PR branch is ahead of nmp/customizer branch (fast-forward)

All submodule changes look good! ✨

@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown

✅ Submodule Fast-Forward Check Results

Check based on commit: e073474 (PR #7 from solu/integration-testing)

✅ Submodules that are properly updated:

Gym: ✅ PR branch is ahead of nmp/customizer branch (fast-forward)
Megatron-Bridge: ✅ PR branch is ahead of nmp/customizer branch (fast-forward)

All submodule changes look good! ✨

Comment thread examples/nemo_gym/run_grpo_nemo_gym.py
Comment thread examples/run_grpo.py
Comment thread nemo_rl/environments/sandbox/host/entrypoint.py
Signed-off-by: Sam Oluwalana <soluwalana@nvidia.com>
Signed-off-by: Sam Oluwalana <soluwalana@nvidia.com>
Signed-off-by: Sam Oluwalana <soluwalana@nvidia.com>
Signed-off-by: Sam Oluwalana <soluwalana@nvidia.com>
Signed-off-by: Sam Oluwalana <soluwalana@nvidia.com>
@soluwalana
soluwalana force-pushed the solu/integration-testing branch from e073474 to 539286d Compare August 6, 2026 18:32
@soluwalana
soluwalana merged commit 97b376e into nmp/customizer Aug 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants