-
Notifications
You must be signed in to change notification settings - Fork 0
Serialization fixes #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Serialization fixes #8
Conversation
|
@deads2k the second patch requires sanity check |
|
removing @liggitt as predicted... |
|
@mfojtik don't forget openshift#16065 |
|
I'd prefer commenting out all references to jsoniter in the file so the import is dropped... too easy for new references to creep in without conflicts on a rebase |
c0b8417 to
fd0ab94
Compare
| func init() { | ||
| // TODO: Remove this once the legacy API will be deprecated. We need this now | ||
| // in order to make the serialization test pass. | ||
| LegacySchemeBuilder.Register(RegisterConversions) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@deads2k is this acceptable? drop in/out and the serialization test is passing with this.
|
@liggitt do you want to drop it entirely from k8s? remove all references, get rid of vendor/ ? |
|
@liggitt i think the only place where it is used right know that matters is the json serializer. There are some occurrences in _tests but nothing that we run I assume. |
fd0ab94 to
a3cf4fe
Compare
|
updated... I comment it out instead of removing and commented the initialisation so we don't import it anymore. |
"\""in DockerImage