Readability of shortcuts #62

[romanr]

I can't fix this myself;

Can't understand where it should be split so tokens like Space treated like single key.
In the end it should look like this:

⇧⌘SPACE

[solomkinmv]

Thanks, I'll take a look!

[solomkinmv]

Sorry for the delay. I'll take a look at the end of the week!

[solomkinmv]

In this case the problem is because of the split.
"Space" gets converted to list of chars ["S", "p", "a", "c", "e"]. While you need to add spacing between modifiers and base key

[romanr]

In this case the problem is because of the split. "Space" gets converted to list of chars ["S", "p", "a", "c", "e"]. While you need to add spacing between modifiers and base key

There's list of all keys (in key-codes.json?)
We need to iterate on key sequence string, in this example we have "⇧⌘SPACE",
and iterating we will find first: shift ⇧ , and output it as singe div,
then we will find ⌘ and output it,
then "Space" is detected as single key because it is present in key-codes, so we output SPACE as single DIV representing one key.

[solomkinmv]

Are you sure that it needs to be global?

Based on the official docs you don't need it: https://nextjs.org/docs/getting-started/installation#manual-installation

[romanr]

Yes -g is mistake, sorry.

[solomkinmv]

@romanr please see my last commit attached. I wrapped each keyboard token in span and added check if it's a symbol or not

[romanr]

@romanr please see my last commit attached. I wrapped each keyboard token in span and added check if it's a symbol or not

Thanks, will check!