Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract admin-app #86

Merged
merged 1 commit into from
Nov 24, 2021
Merged

Extract admin-app #86

merged 1 commit into from
Nov 24, 2021

Conversation

nickray
Copy link
Member

@nickray nickray commented Nov 24, 2021

  • Extract admin-app into its own repo
  • By consequence, also ctaphid-dispatch
  • Removes explicit branch = "main" in git dependencies

For some reason, if there is a mix of explicit branch and implicit ("main" branch from repo POV) git dependencies, even if they're the same commit, Rust treats them as different (leading to "trait not implemented" errors).

The ultimate goal of this exercise is ancillary cleanup in order to test @robin-nitrokey's trussed-dev/ctap-types#2.

@nickray nickray merged commit 7d1d9ec into main Nov 24, 2021
@nickray nickray deleted the extract-admin-app branch November 24, 2021 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant