Handle pin_protocol field in HmacSecretInput #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcecchinato
reviewed
Nov 5, 2021
nickray
reviewed
Nov 24, 2021
nickray
reviewed
Nov 24, 2021
The December 08, 2020 version of the Client to Authenticator Protocol (CTAP) specification added the pinUvAuthProtocol(0x04) field to the input data for the hmac-secret extension in the authenticatorGetAssertion command. This patch checks that the value of this field (if present) is set to 1 as we only support this pin protocol. https://fidoalliance.org/specs/fido-v2.1-rd-20201208/fido-client-to-authenticator-protocol-v2.1-rd-20201208.html
robin-nitrokey
force-pushed
the
hmac-secret
branch
from
9e26a01
to
e055f5d
Compare
|
Rebased onto main and removed the changes to the dependencies. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The December 08, 2020 version of the Client to Authenticator Protocol
(CTAP) specification added the pinUvAuthProtocol(0x04) field to the
input data for the hmac-secret extension in the
authenticatorGetAssertion command. This patch checks that the value of
this field (if present) is set to 1 as we only support this pin
protocol.
https://fidoalliance.org/specs/fido-v2.1-rd-20201208/fido-client-to-authenticator-protocol-v2.1-rd-20201208.html
This is still a draft because it depends on trussed-dev/ctap-types#2.