[WIP | DNM] Remove unecessary apiProduct operations #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SirNexus
approved these changes
Oct 23, 2024
|
Will merge & release after solo-projects PR passes CI (or has no related failures) https://github.com/solo-io/solo-projects/pull/7033 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validated to have fixed credential recreation issue by Denis. This removal is a side effect fix since we no longer need spiProducts + approved-ness in IdP.
Will validate in e2e test in solo-projects as well.
Removing the api product endpoints, and therefore anything related to it.
Updated the url endpoint of the client/oauth creation, since as Aidan previously brought up, technically it's all for oauth2, and we don't need that in the url.
Updated the operation id for deletion to better match the creation one. This was more of a personal change, since parsing through the code I sometimes got confused on the previous naming (
CreateOAuthApplicationandDeleteApplication). When skimming quickly, I sometimes thought they related to different things (an "app" vs an "oauth app") even though it's all the same.