Cherry pick removals #710
Merged
Cherry pick removals #710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 18, 2016 13:22
This isn't used anywhere, doesn't have any tests, and is pretty crazy. fixes spree/spree#5921
This isn't used anywhere in the codebase, doesn't have any tests, and isn't a good idea to use even if you wanted to. Fixes spree/spree#5920
|
👍 But a changelog entry would be great |
cbrunsdon
force-pushed
the
cherry_pick_removals
branch
from
dcf29f7
to
5e0772a
Compare
|
@jhawthorn aye, agreed these could be in a changelog. Added them in another commit. |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These two commits were grabbed from spree 3.0 removing unused helpers, ninja-ing the commits in to help with #690