Show "Unavailable" status for products with a future Available On date
#5734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently if a product has the `available_on` date in the future, it will still show a status of Available, even though it is not available for purchase on the store. This change proposes a new status of `Unavailable` for scheduled products. Co-authored-by: Harmony Bouvier <[email protected]>
This change fixes an issue where certain browsers (namely Firefox) will not render the date field correctly when it contains the full date and time format as the value. This change just truncates the available_on and discontinue_on values to match the precision expected, rather switch to the datetime-local input which is not fully supported in all browsers, but also maintains the old admin behaviour. Co-authored-by: Andrew Stewart <[email protected]>
forkata
force-pushed
the
feature/solidus_admin/show-unavailable-status-products
branch
from
69504bd
to
1fdb686
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5734 +/- ##
=======================================
Coverage 88.84% 88.84%
=======================================
Files 704 704
Lines 16762 16764 +2
=======================================
+ Hits 14892 14894 +2
Misses 1870 1870 ☔ View full report in Codecov by Sentry. |
jarednorman
approved these changes
May 1, 2024
adammathys
approved these changes
May 2, 2024
|
Amazing. Thanks |
|
This is actually a bug fix. I would like to back port this to 3.4 @kennyadsl wdyt? |
|
@tvdeyen I'm good with that, please add the appropriate tags. 🙏 |
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change addresses two issues in the new Solidus admin
Availablestatus - this is resolved by adding a new status asUnavailable, but I am open to suggestions on this. The issue is that currently products with a futureAvailable Ondate still show asAvailablewhich is misleading.FieldUI component - This resolves an issue where the values passed to theFieldcomponent contained the full date and time, which is not valid given we're using an input of typedate. This change ensures that the date is formatted correctly before being passed to the component.Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: