SolidusLegacyPromotion extraction: Move and fix remaining API specs #5694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to move some specs from solidus_legacy_promotions into solidus_legacy_promotions. These specs use routes from the gem. Let's add api as a dependency.
We're keeping the non-promotion-related parts of this spec in core, but the promotion part has to go. For this spec, I don't think it makes sense to stub out all the things.
This spec is not feasible with the promotion system extracted within core. Moving.
This spec was previously already fixed to not refer to any promotion-system-related things, but I forgot this one line in solidusio#5686.
github-actions
bot
added
changelog:solidus_api
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5694 +/- ##
=======================================
Coverage 88.90% 88.90%
=======================================
Files 700 700
Lines 16641 16642 +1
=======================================
+ Hits 14795 14796 +1
Misses 1846 1846 ☔ View full report in Codecov by Sentry. |
tvdeyen
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There were a few specs and assertions I missed in #5686 . These are moved to the
solidus_legacy_promotionsgem in this PR.This also adds a dependency from
solidus_legacy_promotionstosolidus_api.Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: