Add preferences to configure product and taxon images style #4062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
@cpfergus1 thanks for this PR, I like the new configurations for image styles 🖼️
I added a comment for a small optimization, let me know what you think!
cpfergus1
force-pushed
the
image-size-config
branch
3 times, most recently
from
b01c925
to
162d433
Compare
kennyadsl
reviewed
May 19, 2021
This commit adds Spree configuration options for styles which will make it easier to customize product and taxon image styles. Currently, the user would have to create and override file or supercede the current modules ActiveStorageAttachment for either class. This will make editing styles clean and a single step process by allowing users to edit their spree.rb configuration to modify these settings. Included allowed mime types configuration for taxons
cpfergus1
force-pushed
the
image-size-config
branch
from
162d433
to
b1fa1b8
Compare
houndci-bot
reviewed
May 19, 2021
| url: '/spree/taxons/:id/:style/:basename.:extension', | ||
| path: ':rails_root/public/spree/taxons/:id/:style/:basename.:extension', | ||
| default_url: '/assets/default_taxon.png' | ||
|
|
||
| validates_attachment :icon, | ||
| content_type: { content_type: %w[image/jpg image/jpeg image/png image/gif] } | ||
| content_type: { content_type: Spree::Config.allowed_image_mime_types } |
There was a problem hiding this comment.
Layout/AlignArguments: Align the arguments of a method call if they span more than one line.
| @@ -5,14 +5,14 @@ module Spree::Taxon::PaperclipAttachment | |||
|
|
|||
| included do | |||
| has_attached_file :icon, | |||
| styles: { mini: '32x32>', normal: '128x128>' }, | |||
| default_style: :mini, | |||
| styles: Spree::Config.taxon_image_styles, | |||
There was a problem hiding this comment.
Layout/AlignArguments: Align the arguments of a method call if they span more than one line.
Done! |
kennyadsl
changed the title
jarednorman
approved these changes
Jun 1, 2021
forkata
added a commit
to forkata/edgeguides
that referenced
this pull request
Feb 16, 2023
This change to the docs applies to all versions of Solidus since version 3.1 when the preferences for customizing image sizes were added solidusio/solidus#4062.
forkata
added a commit
to forkata/edgeguides
that referenced
this pull request
Feb 16, 2023
This change to the docs applies to all versions of Solidus since version 3.1 when the preferences for customizing image sizes were added solidusio/solidus#4062. Co-authored-by: Cameron Day <[email protected]>
forkata
added a commit
to forkata/edgeguides
that referenced
this pull request
Feb 16, 2023
This change to the docs applies to all versions of Solidus since version 3.1 when the preferences for customizing image sizes were added solidusio/solidus#4062. Co-authored-by: Cameron Day <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds Spree configuration options for styles, which will make
it easier to customize product and taxon image styles. Currently, the
user would have to create an override file or supersede the current
modules ActiveStorageAttachment for either class. This will make editing
styles clean and a single step process by allowing users to edit their
spree.rb configuration to modify these settings.
Description
Checklist: