Improve Active Storage configuration for in-memory Dummy App #3970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is not needed, those migrations are already added by default on any new Rails Application and are not harmful for testing purposes. We could skip them in the installer with `--skip-activestorage` and add them only when we are actually using it but since the long-term goal is to only support Active Storage we can save some ifs and keep those migrations even if we are not using the tables generated.
aldesantis
approved these changes
Mar 5, 2021
jarednorman
approved these changes
Mar 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We have now Active Storage installed by default on new apps. This PR configures the CI to reflect the new default (now it needs an ENV variable to disable it, otherwise it assumes it's enabled), and removes an extra call to install Active Storage migrations.