Consolidation of promotion code batch form fields into partial. #3957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpfergus1
changed the title
|
@cpfergus1 thanks, this looks good to me! I'm not too familiar with this specific part of the code, so I'll let @spaghetticode (who authored the original issue) chime in first to see if this is what he had in mind. |
spaghetticode
approved these changes
Feb 25, 2021
There was a problem hiding this comment.
@cpfergus1 thanks for working on this, the changes look good to me 👍
|
No problem! Glad to head the changes are acceptable |
aldesantis
requested changes
Feb 26, 2021
There was a problem hiding this comment.
@cpfergus1 thanks! Just have one small comment and then we're good. 🙂
backend/app/views/spree/admin/promotion_code_batches/_form_fields.html.erb
Outdated
Show resolved
Hide resolved
kennyadsl
added
the
release:major
kennyadsl
removed
the
release:major
aldesantis
approved these changes
Apr 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request resolves issue 3952
Implemented field for email on pathway 1 for creating promotion code batches (during promotion creation).
Implemented partial for form fields when creating promotion code batches and refactored promotion code batch creation forms.
Implemented conditional for "per code usage limit" to display when promotion id is not present in the page's parameters to prevent breaking pathway 2 for creating promotion code batches
All tests are passing
Pathway 1
Pathway 2
If needed you can reference another PR or issue here, e.g.:
Ref #3952
Checklist: