New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow customize database credentials for test app #3921

Merged

kennyadsl merged 1 commit into solidusio:master from ccarruitero:dummy-database

Feb 18, 2021

Contributor

ccarruitero commented Feb 5, 2021

Description
This allow set postgresql database credentials for dummy app from env variables.

I think not everyone use default postgresql credential, and this will be useful in that cases.

Checklist:

I have followed Pull Request guidelines
I have added a detailed description into each commit message
I have updated Guides and README accordingly to this change (if needed)
I have added tests to cover this change (if needed)
I have attached screenshots to this PR for visual changes (if needed)


          allow customize database credentials for test app

638a57b

kennyadsl approved these changes

View reviewed changes

Member

kennyadsl left a comment

👍 thanks!

kennyadsl added this to the 3.0.0 milestone

jarednorman approved these changes

View reviewed changes

kennyadsl merged commit 68fcf04 into solidusio:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet