Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to maintained Paperclip fork #3913

Merged

Conversation

filippoliverani
Copy link
Contributor

@filippoliverani filippoliverani commented Feb 1, 2021

Description

Since Paperclip dependency is not going away anytime soon, it would be better switching to the official maintained fork to keep up with security updates and Ruby 3 compability.

Paperclip has been deprecated for 3 years and abandoned for a year, the creators suggest to migrate to the maintained fork Paperclip-kt.

Checklist:

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • [ ] I have updated Guides and README accordingly to this change (if needed)
  • [ ] I have added tests to cover this change (if needed)
  • [ ] I have attached screenshots to this PR for visual changes (if needed)

@filippoliverani filippoliverani marked this pull request as ready for review February 1, 2021 10:05
Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the 3.0 release is ok for this kind of change.

@kennyadsl kennyadsl added this to the 3.0.0 milestone Feb 18, 2021
@kennyadsl kennyadsl added type:enhancement Proposed or newly added feature changelog:solidus_core Changes to the solidus_core gem dependencies and removed type:enhancement Proposed or newly added feature labels Feb 18, 2021
Copy link
Member

@jarednorman jarednorman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, I think this is a fine way to go.

@kennyadsl kennyadsl merged commit fd9ad4c into solidusio:master Mar 5, 2021
@kennyadsl kennyadsl deleted the filippoliverani/upgrade-paperclip branch March 5, 2021 13:40
@spaghetticode spaghetticode mentioned this pull request Sep 21, 2021
2 tasks
spaghetticode added a commit that referenced this pull request Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:solidus_core Changes to the solidus_core gem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants