Remove deprecated sass color-#{state} variables usage #3853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the moment they are using deprecated varaibles while we should use the bootstrap variables instead. Having them into the main variables.css file makes this impossible since bootstrap variables are imported after that file. We can't import the bootstrap file before the variables one because bootstrap varaibles are actually using our custom variables.
You can read the value without the need of a multiplication now.
This is not a 1-1 mapping with what we had before but it's very similar.
Instead of $color-success, which is deprecated. They contain the same value and this change has no effect on how the css will look like. $green is what bootstrap uses internally to populate success theme color, that is what we want to use instead of $color-green.
brand-something doesn't exist anymore in boostrap. It's now accessible with theme-color(something).
jarednorman
approved these changes
Dec 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a preparatory PR for #3816 and needs backport.
With 9552ccc we deprecated the following variables in favor of their boostrap counterpart:
$color-successtheme-color(success)$color-noticetheme-color(warning)$color-errortheme-color(danger)This PR is quite complex because we were using these deprecated variables in
variables.scssitself and we can't just swap them to the new version since when this file is imported we didn't import the Boostrap file yet. And there's a reason for that: we define Boostrap colors using the variables defined invariables.scss. 🤯I propose to move the actions related variable in the already existing
actions.scssfile, so that we can define them later, after Boostrap files have been loaded.We preserved the ability to customize those variables per store because they will be still loaded after the
variables_override.scssfile.There's some slight visual change in the colors, due to using the boostrap built-in
theme-color-level()function, instead of sasslighten():Flash Messages
Table rows with highlighted colors