Raise canceling a payment when try_void is not implemented #3844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jarednorman
approved these changes
Nov 17, 2020
The previous (deprecated) behavior was still calling cancel without trying to void the payment first. The actual raise will be handled in Spree::PaymentMethod since it's already present in that class.
kennyadsl
force-pushed
the
kennyadsl/use-try-void-in-payment-cancel
branch
from
bdadfb3
to
8cc77f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The previous (deprecated) behavior was still calling cancel without trying to void the payment first.
The actual raise will be handled in Spree::PaymentMethod since it's already present in that class.
Note: This is part of #3816, but since it's not trivial I'd like to have a more accurate review from the core team, especially from @tvdeyen. 🙏