Fix install instructions in Solidus Guides #3833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As taken from edge guides: solidusio/edgeguides#12 Using --skip-webpack-install is only preventing the Rails install generator from running webacker:install, but the webpacker gem is still added to the Gemfile causing an error when starting the server: 'Webpacker configuration file not found' In the context of a fresh app that uses the bare minimum set of tools to run Solidus we don't need that. People can still add it later if needed. Co-authored-by: Alberto Vena <[email protected]>
ikraamg
changed the title
ikraamg
changed the title
kennyadsl
approved these changes
Nov 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As adopted from @kennyadsl commit on the edge guides solidusio/edgeguides#12:
Using --skip-webpack-install is only preventing the Rails install
generator from running webacker:install, but the webpacker gem is
still added to the Gemfile causing an error when starting the server:
'Webpacker configuration file not found'
In the context of a fresh app that uses the bare minimum set of tools to
run Solidus we don't need that. People can still add it later if needed.
Checklist:
- [ ] I have added tests to cover this change (if needed)- [ ] I have attached screenshots to this PR for visual changes (if needed)