Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for HTML options on image partial #3741

Merged
merged 1 commit into from
Aug 25, 2020
Merged

Allow for HTML options on image partial #3741

merged 1 commit into from
Aug 25, 2020

Conversation

markmead
Copy link
Contributor

@markmead markmead commented Aug 24, 2020

Description
Allows the passing of HTML attributes to the image partial.

Recently added this to a project as I needed a class passed down to the image.

Little unsure if there's a better alternative to options ||= {} so any guidance there would be great! 🙌

Checklist:

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have updated Guides and README accordingly to this change (if needed)
  • I have added tests to cover this change (if needed)
  • I have attached screenshots to this PR for visual changes (if needed)

Copy link
Member

@aldesantis aldesantis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thanks! I think options ||= {} is fine since it follows the convention for other local variables.

@jarednorman jarednorman merged commit 310768c into solidusio:master Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants