Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cancel authorized (pending) payments when cancelling an order (cont.) #3662

Merged
merged 2 commits into from
Jun 23, 2020
Merged

Cancel authorized (pending) payments when cancelling an order (cont.) #3662

merged 2 commits into from
Jun 23, 2020

Conversation

filippoliverani
Copy link
Contributor

@filippoliverani filippoliverani commented Jun 12, 2020 •
edited
Loading

Description
This PR is a rebase and a continuation of #2265

release funds on a credit card auth for cancelled orders whose
payments have been authorized but not yet captured.

Checklist:

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have updated Guides and README accordingly to this change (if needed)
  • I have added tests to cover this change (if needed)
  • I have attached screenshots to this PR for visual changes (if needed)

houndci-bot
houndci-bot reviewed Jun 12, 2020
View reviewed changes
core/spec/models/spree/order_spec.rb Outdated Show resolved Hide resolved
core/spec/models/spree/order_spec.rb Outdated Show resolved Hide resolved
core/spec/models/spree/order_spec.rb Outdated Show resolved Hide resolved
@filippoliverani filippoliverani force-pushed the filippoliverani/cancel-authorized-payments-fix branch 2 times, most recently from 94f7d72 to 15c8193 Compare June 12, 2020 16:08
@jordan-brough @filippoliverani
Consolidate Order#cancel specs
e06114b
@jordan-brough @filippoliverani
Cancel all authorized (pending) payments when cancelling an order
1b1d8e3 
E.g., release funds on a credit card auth for cancelled orders whose
payments have been authorized but not yet captured.

This was already happening for store credit payments.
@filippoliverani filippoliverani force-pushed the filippoliverani/cancel-authorized-payments-fix branch from 15c8193 to 1b1d8e3 Compare June 19, 2020 10:10
@filippoliverani filippoliverani marked this pull request as ready for review June 19, 2020 12:08
kennyadsl
kennyadsl approved these changes Jun 22, 2020
View reviewed changes
Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kennyadsl kennyadsl added changelog:solidus_core Changes to the solidus_core gem Needs Core Team Review labels Jun 22, 2020
@kennyadsl kennyadsl added this to the 2.11 milestone Jun 22, 2020
@kennyadsl kennyadsl mentioned this pull request Jun 22, 2020
Closed
@aldesantis aldesantis merged commit 4b943fb into solidusio:master Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@houndci-bot houndci-bot houndci-bot left review comments

@kennyadsl kennyadsl kennyadsl approved these changes

@aldesantis aldesantis aldesantis approved these changes

@jarednorman jarednorman jarednorman approved these changes

Assignees
No one assigned
Labels
changelog:solidus_core Changes to the solidus_core gem
Projects
None yet
Milestone
2.11
Development

Successfully merging this pull request may close these issues.
6 participants
@filippoliverani @kennyadsl @aldesantis @jarednorman @houndci-bot @jordan-brough