Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add webdrivers gem #3657

Merged
merged 1 commit into from
Jun 11, 2020
Merged

Add webdrivers gem #3657

merged 1 commit into from
Jun 11, 2020

Conversation

peterberkenbosch
Copy link
Contributor

@peterberkenbosch peterberkenbosch commented Jun 7, 2020 •
edited
Loading

Description

Running the feature specs locally is failing for me with Chrome Version 83

Selenium::WebDriver::Error::SessionNotCreatedError:
              session not created: Chrome version must be between 71 and 75
                (Driver info: chromedriver=2.46.628411 (3324f4c8be9ff2f70a05a30ebc72ffb013e1a71e),platform=Mac OS X 10.14.6 x86_64)

Adding the webdrivers gem is solving this problem for me and I suspect others as well.

Checklist:

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have updated Guides and README accordingly to this change (if needed)
  • I have added tests to cover this change (if needed)
  • I have attached screenshots to this PR for visual changes (if needed)

@peterberkenbosch
Add webdrivers gem
f0595bc 
When running the feature specs locally with a recent Chrome version the
selenium webdriver fails with an error that Chrome has to be in a
certain version.

Adding the webdrivers gem and require this in the frontend gem fixes
this.
jarednorman
jarednorman approved these changes Jun 8, 2020
View reviewed changes
Copy link
Member

@jarednorman jarednorman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, I didn't know this gem existed. Seems useful! Thanks Peter!

peterberkenbosch added a commit to peterberkenbosch/solidus that referenced this pull request Jun 9, 2020
@peterberkenbosch
[wip] webdrivers -> seperate PR solidusio#3657
5a79e4f
kennyadsl
kennyadsl approved these changes Jun 11, 2020
View reviewed changes
Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Peter!

@kennyadsl kennyadsl merged commit 65abf66 into solidusio:master Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennyadsl kennyadsl kennyadsl approved these changes

@jarednorman jarednorman jarednorman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@peterberkenbosch @kennyadsl @jarednorman