Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variant property rules to optionally match all conditions (cont.) #3653

Conversation

filippoliverani
Copy link
Contributor

Description
This PR is a rebase and continuation of #2698 and addresses the latest suggested changes.

Checklist:

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • [ ] I have updated Guides and README accordingly to this change (if needed)
  • I have added tests to cover this change (if needed)
  • [ ] I have attached screenshots to this PR for visual changes (if needed)

@filippoliverani filippoliverani changed the title Variant property rules to optionally match all conditions Variant property rules to optionally match all conditions (cont.) Jun 5, 2020
@filippoliverani filippoliverani marked this pull request as ready for review June 5, 2020 15:36
A new `apply_to_all` flag on `VariantPropertyRule` which, if true, only matches
properties to variants if all of the conditions are met. Previously it would match
any conditions which meant you could never apply a specific property to a variant
that had more than one option type.
@filippoliverani filippoliverani force-pushed the filippoliverani/variant-property-rules-all-fix branch from 15a4851 to bf5cd59 Compare June 12, 2020 10:41
Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Filippo!

@kennyadsl kennyadsl merged commit 17c8cf5 into solidusio:master Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants