Bump required Ruby version to 2.5 #3594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support for Ruby 2.4 has been ended, to make sure we keep up with the supported ruby versions this commit bumps the required Ruby version to >= 2.5.0 https://www.ruby-lang.org/en/news/2020/04/05/support-of-ruby-2-4-has-ended/
jarednorman
approved these changes
Apr 27, 2020
There was a problem hiding this comment.
Looks good to me and as far as I understand it this is in line with the discussion in #3302.
gmacdougall
approved these changes
Apr 29, 2020
spaghetticode
approved these changes
Apr 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for Ruby 2.4 has been ended, to make sure we keep up with
the supported ruby versions this commit bumps the required Ruby version
to >= 2.5.0
https://www.ruby-lang.org/en/news/2020/04/05/support-of-ruby-2-4-has-ended/
Description
Checklist: