Deprecate Spree::Address firstname, lastname and full_name #3584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Apr 10, 2020
filippoliverani
changed the title
filippoliverani
force-pushed
the
filippoliverani/deprecate-address-firstname-lastname
branch
from
63f8d30
to
acff1da
Compare
aldesantis
approved these changes
Apr 15, 2020
kennyadsl
reviewed
Apr 16, 2020
Add deprecation warnings and update docs to notify when Spree::Address firstname, lastname and full_name attributes are used instead of name.
When Spree::Config.use_combined_first_and_last_name_in_address preference is set to true, no Address representation should contain any reference to deprecated legacy name attributes.
filippoliverani
force-pushed
the
filippoliverani/deprecate-address-firstname-lastname
branch
from
acff1da
to
12bdceb
Compare
stem
added a commit
to stem/solidus_product_assembly
that referenced
this pull request
Apr 18, 2020
Because of addresses' firstname & lastname deprecations in solidusio/solidus#3584, solidusio/solidus#3524 and probably other PRs, the inputs where deleted in favor of a single `name` input. This is only on master for now, so it should be in 2.11 or 3.0.
stem
added a commit
to stem/solidus_product_assembly
that referenced
this pull request
Apr 18, 2020
Because of addresses' firstname & lastname deprecations in solidusio/solidus#3584, solidusio/solidus#3524 and probably other PRs, the inputs where deleted in favor of a single `name` input. This is only on master for now, so it should be in 2.11 or 3.0.
stem
added a commit
to stem/solidus_product_assembly
that referenced
this pull request
Apr 18, 2020
Because of addresses' firstname & lastname deprecations in solidusio/solidus#3584, solidusio/solidus#3524 and probably other PRs, the inputs where deleted in favor of a single `name` input. This is only on master for now, so it should be in 2.11 or 3.0.
aldesantis
pushed a commit
to stem/solidus_product_assembly
that referenced
this pull request
Apr 25, 2020
Because of addresses' firstname & lastname deprecations in solidusio/solidus#3584, solidusio/solidus#3524 and probably other PRs, the inputs where deleted in favor of a single `name` input. This is only on master for now, so it should be in 2.11 or 3.0.
MassimilianoLattanzio
added a commit
to nebulab/solidus_address_name
that referenced
this pull request
Aug 11, 2023
In solidusio/solidus#3584, they changed the address factory [1], so the firstname and lastname will differ from the previous version. This commits reverts the changes, so if in your applications test you're using the old address factory, the specs will continue to work properly. 1: https://github.com/solidusio/solidus/pull/3584/files#diff-8e88fbe32e58692ffaf3629a7fdfdadfa4378dd248a011fc8d2d266a5ed299a4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is a step to solve #3234 and a continuation of #3524.
Address#nameis ready to be used instead offirstname,lastnameandfull_name, we should start to deprecate legacy attributes to be ready to remove them in the next major release.This PR adds deprecation warnings and removes any remaining reference to legacy attributes.
Checklist:
[ ] I have attached screenshots to this PR for visual changes (if needed)