Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove non-existing middleware #3570

Merged
merged 1 commit into from
Apr 3, 2020
Merged

Conversation

coorasse
Copy link
Contributor

@coorasse coorasse commented Mar 29, 2020

Am I missing something? This middleware does not exist and therefore cannot be loaded.
It should be here, right? https://github.com/solidusio/solidus/tree/master/backend/lib/spree/backend
On the other side, the Frontend one is present: https://github.com/solidusio/solidus/tree/master/frontend/lib/spree/frontend/middleware

This instruction makes the installation of solidus_backend fail. 😢

Am I missing something? This middleware does not exist and therefore cannot be loaded.
It should be here, right? https://github.com/solidusio/solidus/tree/master/backend/lib/spree/backend
On the other side, the Frontend one is present: https://github.com/solidusio/solidus/tree/master/frontend/lib/spree/frontend/middleware
@kennyadsl
Copy link
Member

Hey @coorasse, thanks for this PR. It's quite creepy that we had this middleware call there but the system was not complaining. Which error are you seeing exactly?

@coorasse
Copy link
Contributor Author

coorasse commented Mar 30, 2020

NoMethodError:
            undefined method `new' for "Spree::Backend::Middleware::SeoAssist":String

I can create a gist later if needed.
And if I change it to the class, instead of the string, it cannot find it.
I find this also pretty creepy...I couldn't really understand it, and also I didn't put too much effort into trying to understand it since this class really does not exist.

@kennyadsl
Copy link
Member

Does it happen when you start the rails server on your own host application? And, are you requiring the main gem 'solidus' or via individual sub-components (solidus_backend, solidus_core)?

@coorasse
Copy link
Contributor Author

Individual subcomponents. solidus_backend and solidus_core.
I am currently investigating, it could be related to:

mount Spree::Core::Engine, at: '/'
mount Spree::Backend::Engine, at: '/'

?

@coorasse
Copy link
Contributor Author

git clone [email protected]:renuo/solidus_engine_issue.git
cd solidus_engine_issue
bin/setup
bundle exec rake
cat log/test.log

@kennyadsl
Copy link
Member

Probably unrelated, there's no need to mount backend routes manually. They are injected into the Spree::Core routes.

This makes me think that maybe we never call Spree::Backend::Engine in the whole application and, being not loaded or accessed, it never crashes.

@aldesantis aldesantis merged commit 99c6ba9 into solidusio:master Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants