Add CircleCI job to run tests against Rails master #3557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennyadsl
reviewed
Mar 13, 2020
filippoliverani
force-pushed
the
filippoliverani/add-circleci-rails-master-job
branch
from
18d6162
to
b7ce9ee
Compare
@kennyadsl nope, missed that, added to workflow, thank you |
filippoliverani
force-pushed
the
filippoliverani/add-circleci-rails-master-job
branch
from
b7ce9ee
to
c957614
Compare
spaghetticode
approved these changes
Mar 16, 2020
aldesantis
approved these changes
Mar 16, 2020
|
@filippoliverani thanks! One of many steps towards making Solidus even more future-proof. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a CircleCI job to run tests against Rails master. Right now it's needed to bring forward the work to support ActiveStorage and could be useful to spot as soon as possible potentially breaking changes brought in by Rails new features.
The job could be disabled or set as a non-blocking status check in Github's branch protection rules to avoid blocking unrelated PRs.
Checklist: