Improve gemspecs of solidus and subcomponents #3546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are no file of that type in the solidus_api gem
This commit just changes the inner block variable `gem` to `s`, to reflect what we do in other gemspecs. It also reorder items so it's easy to find gemspecs pieces where we have them in the gemspec of the other components.
The deafult value is 'lib', no need to keep it. https://guides.rubygems.org/specification-reference/#require_paths=
To reflect the position we have in other gemspecs
This option tells which system requirements are needed in order for Solidus to work. 'none' isn't really telling anything.
gmacdougall
approved these changes
Mar 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors gemspecs of Solidus and all its subcomponents mainly to make them uniform.
Having them in the same format makes it easier to find information for users that are navigating and comparing them since they already know where to find information.
It also removes specs for the gem builds, since they are not used and increase the package size without any real benefits.
For what is worth, here's the exact saving:
With a size decrease of 22% if we don't consider solidus_sample
Checklist:
[ ] I have updated Guides and README accordingly to this change (if needed)[ ] I have added tests to cover this change (if needed)[ ] I have attached screenshots to this PR for visual changes (if needed)