Replace ActiveJob::TestHelper with own module. #3543
Conversation
|
@kennyadsl assigning you as a reviewer here because you made the original issue and I'm not 100% sure this is what you had in mind? Let us know! Also, @jessetilro congrats on your first contribution and thanks! Looking forward to seeing you more. |
|
@aldesantis the original issue was made by @filippoliverani. We discussed IRL about this and I think it's quite different from what we had in mind but I'm sure he is able to explain it better than me. |
|
@kennyadsl The proposed solution in the issue was to stop calling I think that this PR is good a first step in that direction, it has a moderate impact on code but effectively removes |
|
@filippoliverani thanks for this review! I'm fine with this, @jessetilro can you please just fix the comments left in the review? Thanks again! 🙏 |
According to review feedback on solidusio#3543.
Resolves issue solidusio#3526. The test code does no longer rely on ActiveJob::TestHelper. The only method used from this module was perform_enqueued_jobs. I implemented a method providing this functionality in an own testing helper module, such that existing test cases do not have to be changed and remain readable.
According to review feedback on solidusio#3543.
jessetilro
force-pushed
the
refactor-job-test-helpers
branch
from
a68118e
to
eabfd55
Compare
|
@kennyadsl I fixed the comments in the review. |
kennyadsl
added
Needs Core Team Decision
changelog:solidus_core
According to review feedback on solidusio#3543.
According to review feedback on solidusio#3543.
According to review feedback on solidusio#3543.
Issue #3526.
Description
This is my first contribution. I decided to make an attempt to resolve this issue as it was flagged as "Good First Issue". Looking forward to your feedback!
The test code does no longer rely on
ActiveJob::TestHelper.The only method used from this module was
perform_enqueued_jobs.I implemented a method providing this functionality in an own testing helper module,
such that existing test cases do not have to be changed and remain readable.
Checklist: