Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove RABL remnants #3425

Merged
merged 1 commit into from
Nov 18, 2019

Conversation

JuanCrg90
Copy link
Contributor

Description
RABL was removed from the project on version 2.4.0 (See #2147 #2146).
This updates the responder template to match with Jbuilder and updates
the README file.

Checklist:

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have updated Guides and README accordingly to this change (if needed)
  • I have added tests to cover this change (if needed)
  • I have attached screenshots to this PR for visual changes (if needed)

Copy link
Member

@spaghetticode spaghetticode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuanCrg90 thank you!

Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just left a backward compatibility improvement, thanks for this change, @JuanCrg90@

RABL was removed from the project on version 2.4.0 (See solidusio#2147 solidusio#2146).
This updates the responder template to match with Jbuilder and updates
the README file.
Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it’s perfect now, thanks!

@kennyadsl kennyadsl merged commit 90d60c3 into solidusio:master Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants