Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[doc] Document the config assigment for vat_country_iso #3386

Merged
merged 1 commit into from
Oct 22, 2019
Merged

[doc] Document the config assigment for vat_country_iso #3386

merged 1 commit into from
Oct 22, 2019

Conversation

peterberkenbosch
Copy link
Contributor

This commit fixes the sample config by using = instead of == for
setting the admin_vat_country_iso

Description

Checklist:

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have updated Guides and README accordingly to this change (if needed)
  • I have added tests to cover this change (if needed)

@peterberkenbosch
[doc] Document the config assigment for vat_country_iso
8c648a8 
This commit fixes the sample config by using `=` instead of `==` for
setting the `admin_vat_country_iso`
jacobherrington
jacobherrington approved these changes Oct 20, 2019
View reviewed changes
Copy link
Contributor

@jacobherrington jacobherrington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks @peterberkenbosch!

spaghetticode
spaghetticode approved these changes Oct 20, 2019
View reviewed changes
Copy link
Member

@spaghetticode spaghetticode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@peterberkenbosch thank you!

@spaghetticode spaghetticode merged commit 3ba2ba3 into solidusio:master Oct 22, 2019
@peterberkenbosch peterberkenbosch deleted the fix-typo-in-vat-documentation branch November 19, 2019 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spaghetticode spaghetticode spaghetticode approved these changes

@jacobherrington jacobherrington jacobherrington approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@peterberkenbosch @spaghetticode @jacobherrington