Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct misspelling in API Documentation for Create Product #3370

Merged
merged 1 commit into from
Oct 24, 2019
Merged

Correct misspelling in API Documentation for Create Product #3370

merged 1 commit into from
Oct 24, 2019

Conversation

octoxan
Copy link
Contributor

@octoxan octoxan commented Oct 8, 2019

"Creates" in the header was misspelled as "Creaets". This is just a quick fix.

Checklist:

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have updated Guides and README accordingly to this change (if needed)
  • I have added tests to cover this change (if needed)

@spaghetticode
Copy link
Member

@octoxan can you please rebase with master, so we get a green CI? Thank you 🙏 💚

end

before do
stock_location.stock_items.update_all(count_on_hand: 10)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rails/SkipsModelValidations: Avoid using update_all because it skips validations.

@octoxan
Copy link
Contributor Author

octoxan commented Oct 18, 2019

@spaghetticode done

@spaghetticode
Copy link
Member

@octoxan something went wrong with the rebase, your PR has now 23 commits from other people

@octoxan
Copy link
Contributor Author

octoxan commented Oct 21, 2019 via email

@octoxan
Copy link
Contributor Author

octoxan commented Oct 21, 2019

There we go.

Copy link
Member

@spaghetticode spaghetticode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@octoxan thank you 👍

@spaghetticode spaghetticode merged commit 0cc177b into solidusio:master Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants