Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update guides node-sass dependency to be compatible with Node versions > v10 #3359

Merged
merged 1 commit into from
Oct 3, 2019
Merged

Update guides node-sass dependency to be compatible with Node versions > v10 #3359

merged 1 commit into from
Oct 3, 2019

Conversation

octoxan
Copy link
Contributor

@octoxan octoxan commented Oct 1, 2019 •
edited
Loading

Description
Updated the node-sass dependency for the guides/documentation since it was explicitly set to a version which does not work with newer versions of Node. Tested and now yarn install no longer errors on Node v11 or v12, and still works with older versions.

Checklist:

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • [not needed] I have updated Guides and README accordingly to this change (if needed)
  • [not needed] I have added tests to cover this change (if needed)

@octoxan
Update node-sass dependency to be compatible with Node versions > v10
991c701 
The guides for running the documentation locally to make contributions
didn't work if you were on a newer version of node. Node v11 and v12
both threw an error about node-sass. Node-sass version now set to one
that works with newer and older node versions.
@octoxan octoxan changed the title Update node-sass dependency to be compatible with Node versions > v10 Update guides node-sass dependency to be compatible with Node versions > v10 Oct 1, 2019
kennyadsl
kennyadsl approved these changes Oct 2, 2019
View reviewed changes
Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 👍

spaghetticode
spaghetticode approved these changes Oct 2, 2019
View reviewed changes
Copy link
Member

@spaghetticode spaghetticode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@octoxan thank you 🚀

@spaghetticode spaghetticode merged commit 1098bfb into solidusio:master Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spaghetticode spaghetticode spaghetticode approved these changes

@kennyadsl kennyadsl kennyadsl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@octoxan @spaghetticode @kennyadsl