Deprecate Rails 5.1 #3333
Merged
Deprecate Rails 5.1 #3333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rails 5.1 will not be suported from Solidus starting from the next version. It is in its EOL phase and will not receive security patches anymore.
No need to run tests against Rails 5.1, it's deprecated.
It was already obsolete starting with Rails 5.1.
tvdeyen
approved these changes
Sep 18, 2019
| Read more on upgrading from Rails 5.1 to Rails 5.2 here: | ||
| https://guides.rubyonrails.org/upgrading_ruby_on_rails.html#upgrading-from-rails-5-1-to-rails-5-2 | ||
|
|
||
| HEREDOC |
spaghetticode
approved these changes
Sep 20, 2019
|
I've one doubt here: if we remove testing against Rails 5.1 in the CI, we'll never notice if we are introducing breaking changes for Rails 5.1. Not sure I still want to remove it, we'll talk in the next core team meeting maybe? |
gmacdougall
approved these changes
Oct 2, 2019
|
Merging without 5.1 tests to be run. They have been removed from CircleCI with this same PR. |
waiting-for-dev
added a commit
to nebulab/solidus
that referenced
this pull request
Jun 23, 2022
Rails 5.2 reached EOL on June 1st, 2022 [1]. We're going to deprecate it on Solidus v3.2, and remove support on the next major. - We warn when we detect that version is used. - We remove the Rails 5.2 job in the CI. - We remove branching on Rails 5.2 in the specs. We've taken solidusio#3333 for inspiration. - [1] - https://guides.rubyonrails.org/maintenance_policy.html
Merged
waiting-for-dev
added a commit
to nebulab/solidus
that referenced
this pull request
Jun 23, 2022
Rails 5.2 reached EOL on June 1st, 2022 [1]. We're going to deprecate it on Solidus v3.2, and remove support on the next major. - We warn when we detect that version is used. - We remove the Rails 5.2 job in the CI. - We remove branching on Rails 5.2 in the specs. We've taken solidusio#3333 for inspiration. - [1] - https://guides.rubyonrails.org/maintenance_policy.html
waiting-for-dev
added a commit
to nebulab/solidus
that referenced
this pull request
Jun 24, 2022
Rails 5.2 reached EOL on June 1st, 2022 [1]. We're going to deprecate it on Solidus v3.2, and remove support on the next major. - We warn when we detect that version is used. - We remove the Rails 5.2 job in the CI. - We remove branching on Rails 5.2 in the specs. We've taken solidusio#3333 for inspiration. - [1] - https://guides.rubyonrails.org/maintenance_policy.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes Rails 5.1 from our CI and prints a warning message in the Rails console for users who are still using Rails 5.1.
After the next version release (
2.10?), we can merge #3328 and complete this transition.Checklist:
- [ ] I have updated Guides and README accordingly to this change (if needed)- [ ] I have added tests to cover this change (if needed)