Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tab background color, too dark #3311 #3320

Merged
merged 1 commit into from
Aug 31, 2019
Merged

Fix tab background color, too dark #3311 #3320

merged 1 commit into from
Aug 31, 2019

Conversation

Ajmal
Copy link
Contributor

@Ajmal Ajmal commented Aug 30, 2019

Description

In solidus backend I noticed that non active tabs have a dark background color, that makes the tab title unreadable.

Ref #3311

Checklist:

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have updated Guides and README accordingly to this change (if needed)
  • I have added tests to cover this change (if needed)

spaghetticode
spaghetticode approved these changes Aug 30, 2019
View reviewed changes
Copy link
Member

@spaghetticode spaghetticode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ajmal thank you for your contribution 🎉

I think the new color looks good 👍
Schermata 2019-08-30 alle 18 08 22

jacobherrington
jacobherrington approved these changes Aug 31, 2019
View reviewed changes
Copy link
Contributor

@jacobherrington jacobherrington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this change @Ajmal! 👏

tvdeyen
tvdeyen approved these changes Aug 31, 2019
View reviewed changes
Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@tvdeyen tvdeyen merged commit 06147a1 into solidusio:master Aug 31, 2019
@tvdeyen
Copy link
Member

tvdeyen commented Aug 31, 2019

There is no need to wait 24h for a CSS :)

This was referenced Sep 18, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tvdeyen tvdeyen tvdeyen approved these changes

@spaghetticode spaghetticode spaghetticode approved these changes

@jacobherrington jacobherrington jacobherrington approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Ajmal @tvdeyen @spaghetticode @jacobherrington