Add docs for partials that need to be provided #3300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennyadsl
requested changes
Aug 12, 2019
skukx
force-pushed
the
add-docs-for-payment-methods
branch
from
9daddb2
to
359acdf
Compare
|
@skukx not sure what's happened here, can you please restart the build in your CircleCI account? |
skukx
force-pushed
the
add-docs-for-payment-methods
branch
2 times, most recently
from
9b4889d
to
14827ce
Compare
Due to !2513 we need to provide a partial for solidus_api to render a payment method. This is much like how payment methods need to provide partials for the solidus_backend and solidus_frontend. The documentation does not yet reflect this. Include documentation for providing this partial on the api side.
skukx
force-pushed
the
add-docs-for-payment-methods
branch
from
14827ce
to
c4d4ed5
Compare
kennyadsl
approved these changes
Aug 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Due to #2513 we need to provide a partial for the api to render a
payment method.
Checklist: