Attempt to fix flaky specs #3278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennyadsl
force-pushed
the
kennyadsl/fix-flaky-attempt
branch
2 times, most recently
from
8b5effc
to
19a8552
Compare
mdesantis
reviewed
Aug 7, 2019
|
|
||
| expect(find(".flash")).to have_text "Product \"#{product.name}\" has been successfully updated!" | ||
| within('.flash') do | ||
| expect(page).to have_content("Product \"#{product.name}\" has been successfully updated!") |
There was a problem hiding this comment.
What about taking advantage of this change in order to improve string interpolation avoiding escaping double quotes? I was thinking something like this:
%(Product "#{product.name}" has been successfully updated!)
This is an attempt to fix a flaky spec that we have: https://circleci.com/gh/nebulab/solidus/2687#tests/containers/1 Using a more standard way of checking HTML elements state for Capybara could fix the issue since it could not be waiting for the button to change state with the current code.
kennyadsl
force-pushed
the
kennyadsl/fix-flaky-attempt
branch
from
19a8552
to
cc1601e
Compare
This is an attempt to fix a flaky spec: https://circleci.com/gh/nebulab/solidus/2686#tests/containers/1 Probably using this method, Capybara will wait for the page to display the flash message before making the expectation fail.
Without this line we have a flaky spec probably due to select2 not closing its fixed overlay correctly. We've notice that the submit button wasn't pressed at all when we had failures. This means something is preventing the click to happen. The select2 plugin has a lot of code that interacts with other page elements preventing clicks so that could be the root cause. Clicking anywhere in the page before submit apparently solves the issue.
kennyadsl
force-pushed
the
kennyadsl/fix-flaky-attempt
branch
from
cc1601e
to
401278d
Compare
jacobherrington
approved these changes
Aug 8, 2019
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is an attempt to fix a couple of flaky specs that we have:
Using a more standard way of checking HTML elements state for Capybara could fix the issue since, using the current code, it could not be waiting for the element to change state/appear on the page.
Labeled as WIP. I'd like to re-run specs a lot of times before merge. Progress can be monitored here:
https://circleci.com/gh/nebulab/workflows/solidus/tree/kennyadsl%2Ffix-flaky-attempt
Checklist:
- [ ] I have updated Guides and README accordingly to this change (if needed)- [ ] I have added tests to cover this change (if needed)