Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload new sample images #3270

Merged
merged 2 commits into from
Aug 13, 2019

Conversation

mfrecchiami
Copy link
Contributor

The sample images of the online store demo has been updated with new items, branded by Solidus and by a redesigned version of the Ruby logo.

Also image sizes has been changed, to support the retina screens (but maybe an helper that load @2x pictures on retina screens only, could be useful).
The smaller size called mini is still the same: the issue is that on the product page (and somewhere in the backend, also) there is any width or max-width defined, for the thumbnail list item.

new_products_home

I noticed that where are more than two colors variant, there is no way to show all thumbnails.
Actually the thumbs are (in order):

  • the home page product image

  • the thumbs related to the variant selected by the default Variants input radio

3_colors_2_thumbs

IMO on the product page, it could be better show first the item with the same variation, e.g. color, that is shown on the home page.
For now it is possible only to put same color variation as the first option in Variations list, but then all the thumbs shows the same color, so it seems like duplicated items (until the user select another option).

@mfrecchiami mfrecchiami force-pushed the mfrecchiami/update-sample-images branch from e3cd2f1 to 51cab0f Compare July 12, 2019 17:34
Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is long overdue. Thanks

sample/db/samples/product_properties.rb Outdated Show resolved Hide resolved
@mfrecchiami mfrecchiami force-pushed the mfrecchiami/update-sample-images branch from 51cab0f to 1de4a8f Compare July 15, 2019 07:49
Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I'd merge this after we release 2.9 though.

For the thumbnails issue you raised, I think you are right. Maybe a simple solution could be just hiding "All" images when a specific variant is selected and that variant has at least one image.

@mfrecchiami
Copy link
Contributor Author

@kennyadsl thanks 👍

The goal, is to have a product page like this:
[Considering a product with multiple variation colors and which Black is the color showed on home page]

sample

@kennyadsl
Copy link
Member

We'll need an extensive CHANGELOG entry on this one since users could be relying on those images size and updating Solidus could be dangerous for their layout.

Copy link
Contributor

@jacobherrington jacobherrington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look awesome! I agree with merging this after 2.9 👍

@jacobeubanks
Copy link

Love the refresh! I think it's important for potential users to see a more modern store demo and this is a big step toward that.

@kennyadsl
Copy link
Member

@mfrecchiami can you please rebase this one as well when you have time? (no hurry!)

@mfrecchiami mfrecchiami force-pushed the mfrecchiami/update-sample-images branch from 1de4a8f to d6867d6 Compare July 19, 2019 08:46
Copy link
Contributor

@ericsaupe ericsaupe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be worth noting the changes to the attachment sizes

@kennyadsl
Copy link
Member

@mfrecchiami sample/db/samples/products.rb is changed on master, can you please rebase when you have time? 🙏

Refresh sample images of the store demo, with items branded by Solidus and by a
redesigned version of the Ruby logo.

Update the image sizes to support the retina screens (is not an appropriate
way, maybe we need an helper that load bigger images only on retina screens),
except the smaller one preview that is in use on the product page when there
are many variants, and in admin area on product list; the issue is that on the
product page there is any max-width defined for the thumbnail list items.
@mfrecchiami mfrecchiami force-pushed the mfrecchiami/update-sample-images branch from d6867d6 to 2116c35 Compare August 8, 2019 08:59
@mfrecchiami
Copy link
Contributor Author

@kennyadsl now the branch is updated!

@kennyadsl
Copy link
Member

It might be worth noting the changes to the attachment sizes

@ericsaupe yes, a CHANGELOG entry for that should be enough, what do you think? If someone is relying on those sizes we can provide instructions to easily change them back.

@kennyadsl kennyadsl merged commit 01d72a9 into solidusio:master Aug 13, 2019
@kennyadsl kennyadsl deleted the mfrecchiami/update-sample-images branch August 13, 2019 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants