Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify README instructions for Sandbox #3231

Merged
merged 1 commit into from
Jun 18, 2019
Merged

Clarify README instructions for Sandbox #3231

merged 1 commit into from
Jun 18, 2019

Conversation

k1bs
Copy link
Contributor

@k1bs k1bs commented Jun 17, 2019

Clarifies instructions on instantiating sandbox app with an alternate
database type.

Description
At the request of @jacobherrington, this PR clarifies the documentation on how to instantiate a sandbox app using alternate database types.

Checklist:

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have updated Guides and README accordingly to this change (if needed)
  • I have added tests to cover this change (if needed)

Copy link
Contributor

@jacobherrington jacobherrington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making a PR @k1bs! 🎉 I agree that this is confusing because it seems like DB might be a flag for the rake task.

I have a suggestion, but I want your opinion on it because it's very subjective.

README.md Outdated Show resolved Hide resolved
Clarifies instructions on instantiating sandbox app with an alternate
database type.
@k1bs
Copy link
Contributor Author

k1bs commented Jun 17, 2019

Squashed.

Copy link
Contributor

@jacobherrington jacobherrington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the documentation better! 📜

Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jacobherrington jacobherrington merged commit 9ff5eb1 into solidusio:master Jun 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants