Add preferred_reimbursement_type_id as permitted attributes for ReturnAuthorization #3215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericsaupe
reviewed
May 29, 2019
|
@ericsaupe I've added the field in the spec. Thanks |
kennyadsl
approved these changes
May 30, 2019
kennyadsl
changed the title
houndci-bot
reviewed
Jun 17, 2019
api/spec/requests/spree/api/return_authorizations_controller_spec.rb
Outdated
Show resolved
Hide resolved
api/spec/requests/spree/api/return_authorizations_controller_spec.rb
Outdated
Show resolved
Hide resolved
|
Thank you @ibudiallo, just one last thing: can you please squash commits into a single one? |
jacobherrington
approved these changes
Jun 18, 2019
There was a problem hiding this comment.
Thanks for making this change @ibudiallo! Would you mind squashing your commits? I'm happy to merge after that 🎉
|
Thanks guys. I squashed my commits. |
|
Hey @ibudiallo I'd love to merge this PR but it should have a single commit. Maybe you rebased against your local copy of solidus, which is a bit behind the upstream one? I suggest you to add a new upstream remote and redo the rebase: git remote add upstream [email protected]:solidusio/solidus.git
git fetch -a upstream
git rebase upstream/masterThis would clean-up the branch, I'm available here or on our Slack Workspace for further help if needed. Thanks! |
kennyadsl
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using the api, we can create return authorizations but cannot set the reimbursement type. The reason being the field
preferred_reimbursement_type_idwas not included in the list of permitted attributes.Checklist: