Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error messages for wallet payment source #3196

Merged
merged 1 commit into from
May 9, 2019
Merged

Improve error messages for wallet payment source #3196

merged 1 commit into from
May 9, 2019

Conversation

kennyadsl
Copy link
Member

Description

Users that will see those errors will probably don't know what a Spree::PaymentSource is.

This follows up #3007.

Checklist:

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have added tests to cover this change (if needed)

@kennyadsl
Improve error messages for wallet payment source
23a7c3a 
Users that will see those errors will probably don't know what a
Spree::PaymentSource is.
@kennyadsl kennyadsl self-assigned this May 2, 2019
aitbw
aitbw approved these changes May 3, 2019
View reviewed changes
Copy link
Contributor

@aitbw aitbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

jacobherrington
jacobherrington approved these changes May 6, 2019
View reviewed changes
Copy link
Contributor

@jacobherrington jacobherrington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I am good with these! Thanks @kennyadsl

ericsaupe
ericsaupe approved these changes May 6, 2019
View reviewed changes
Copy link
Contributor

@ericsaupe ericsaupe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better!

@kennyadsl kennyadsl merged commit fac7d3c into solidusio:master May 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericsaupe ericsaupe ericsaupe approved these changes

@aitbw aitbw aitbw approved these changes

@jacobherrington jacobherrington jacobherrington approved these changes

Assignees

@kennyadsl kennyadsl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kennyadsl @ericsaupe @aitbw @jacobherrington