Disable adjust stock field when user does not have the correct permission #3163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems like two unrelated payment specs failed. I'm guessing as part of #3160 ? |
|
@seand7565 Hey there! Can you please rebase against master so we'll see the CI green, thanks! |
seand7565
force-pushed
the
stock_display_fix
branch
from
84d1df5
to
06b4991
Compare
ericsaupe
approved these changes
May 6, 2019
jacobherrington
approved these changes
May 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, if you only have display permission for StockItems, you can still see and interact with the stock edit field on the Stock Item page. When you attempt to submit, the API returns 401 unauthorized - however this might be confusing to admin users who don't know about their permission level.
This PR disables the stock edit field (and "Back Orderable" tick boxes) if you do not have the correct permissions to edit stock items, with an explanation tooltip as to why you can't edit the stock items.
This should solve issue #2241
Checklist: