Deprecate @payment_sources ivar in checkout controller #3128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default Rails class does not allow to pass a custom message to the deprecation. This custom class extends its behavior to make it possible. Note that I also opened a PR in Rails for fixing this: rails/rails#35442
This method returns payment sources of the current user. It is no more used into our frontend. We used to assign the content of this method into an ivar (@payment_sources) into the checkout payment step. This method is here only to be able to deprecate this ivar and will be removed.
kennyadsl
changed the title
jacobherrington
approved these changes
Mar 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This method returns payment sources of the current user. It is no more used in our frontend. We used to assign the content of this method into an ivar (@payment_sources) into the checkout payment step. The new
deprecated_payment_sourcesmethod is here only to be able to deprecate this ivar and will be removed with the ivar itself.Trying to call this method in a view (for example
@payment_sources.empty?) will produce this warning:Note
I had to introduce a custom class to deprecate instance variables passing a custom message otherwise we would have a misleading deprecation message:
I also opened a PR in Rails to improve this: rails/rails#35442
Checklist: