Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tenative fix for flaky spec #3110

Merged
merged 1 commit into from
Feb 20, 2019

Conversation

spaghetticode
Copy link
Member

Checking the flash message after form submission may clarify if this flaky spec
failure is caused by something unexpected before submitting the form.

Also, this helps in delaying the failing expectation, as the page DOM and
HTML should be fully updated by that time.

Checking the flash message after form submission may clarify if this flaky spec
failure is caused by something unexpected before submitting the form.

Also, this helps in delaying the failing expectation, as the page DOM and
HTML should be fully updated by that time.
@kennyadsl
Copy link
Member

Rerunning our CircleCI workflow several times to see if the problem happens again, Thanks @spaghetticode !

Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-run the CI like 3-4 times without a failure. Thanks @spaghetticode!

@kennyadsl
Copy link
Member

@solidusio/core-team can we have another review here, please?

Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accessing database values in browser driven feature specs is never a good idea, although pretty widely used... 😞

Thanks for the fix! 👍

@kennyadsl kennyadsl merged commit 6f2bd16 into solidusio:master Feb 20, 2019
@kennyadsl kennyadsl deleted the spaghetticode/taxon-flaky-spec branch February 20, 2019 21:59
@kennyadsl
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants