Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial shipments documentation for end users #3092

Merged

Conversation

kennyadsl
Copy link
Member

@kennyadsl kennyadsl commented Feb 8, 2019

Description
This PR reopens #2784 which has been abandoned. 🙁

These are good, and already approved changes so I think we can resume that work.

Checklist:

@kennyadsl kennyadsl self-assigned this Feb 8, 2019
@kennyadsl kennyadsl changed the title Kennyadsl/user guides/settings/shipping Add initial shipments documentation for end users Feb 8, 2019
@kennyadsl kennyadsl added the WIP label Feb 8, 2019
@kennyadsl
Copy link
Member Author

This is currently not linked anywhere in public guides pages. To try this out, this is visible into https://deploy-preview-3092--solidus-guides.netlify.com/users/settings/overview/

I think some paths have to be adjusted so I added WIP label.

@benjaminwil
Copy link
Contributor

This is currently not linked anywhere in public guides pages.

I have a PR open to address the need for multiple tables of contents in the guides: #2770.

I am happy to pick it up again and rebase it if y'all would consider merging it.

@kennyadsl
Copy link
Member Author

@benjaminwil I’ve just started resuming exactly that PR! 😃

I’ve already rebased and added something, I’ll submit a PR soon and maybe you could help reviewing that one?

@kennyadsl kennyadsl force-pushed the kennyadsl/user_guides/settings/shipping branch from c71936e to 52f8de5 Compare February 18, 2019 18:04
@kennyadsl kennyadsl removed the WIP label Feb 18, 2019
benjaminwil and others added 3 commits February 19, 2019 10:23
This commit improves the user experience of the "Stores" page in the
admin interface in the following ways:

- It clarifies what the "Code" field does.
- It renames the the code field "Slug" in the UI only. This is less
  ambiguous for users who are creating a new store and don't know what
  to put in this field.
- It ensures that all of the fields on the page have the same
  capitalization style.

Note: The UX is still pretty bad. We do not want admins to think making
changes to stores is trivial. We should rethink this page and make more
major changes to it.

Mark "Name" as required for new shipping methods
-----------------------------------------------------------------------

When a store admin creates a new shipping method, the "Name" field
should be marked as required.

This commit also cleans up some extra spacing in the new shipping method
form and fixes the data hook for `admin_name`, which was mis-named to
say `internal_name`.

Update locales strings
-----------------------------------------------------------------------

This commit removes unused locales strings.
This commit adds information about everything store administrators need
to get started with the `solidus_backend` interface at the URI
`/admin/settings/shipping`.

- Tweak product SEO docs; add links to stores docs
- Add all settings article stubs
- Add shipping settings docs for end users
- Adds information about shipping calculators and stock locations.
@kennyadsl kennyadsl force-pushed the kennyadsl/user_guides/settings/shipping branch from 52f8de5 to ca89bae Compare February 19, 2019 09:23
@kennyadsl
Copy link
Member Author

@solidusio/core-team @benjaminwil Can I have a review here, please? 🙏

Copy link
Contributor

@aitbw aitbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work in here @benjaminwil 👏 thanks a lot for finishing this PR, @kennyadsl 🙌

Copy link
Contributor

@jacobherrington jacobherrington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 📖 Thanks @benjaminwil and @kennyadsl

@kennyadsl
Copy link
Member Author

@solidusio/core-team can I have another review here, please? 🙏

Copy link
Contributor

@ericsaupe ericsaupe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@kennyadsl kennyadsl merged commit f271140 into solidusio:master Mar 13, 2019
@kennyadsl kennyadsl deleted the kennyadsl/user_guides/settings/shipping branch March 13, 2019 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants