fix sed call so it works on mac #3091

peterberkenbosch · 2019-02-08T14:06:28Z

before:

sed: 1: "Gemfile": extra characters at the end of G command

this commit tries to make it work on all systems. Might not work on Windows systems though.

Description

Checklist:

I have followed Pull Request guidelines
I have added a detailed description into each commit message
I have updated Guides and README accordingly to this change (if needed)
I have added tests to cover this change (if needed)
I have added a CHANGELOG entry for this change (if needed)

before: ``` sed: 1: "Gemfile": extra characters at the end of G command ``` this commit tries to make it work on all systems. Might not work on Windows systems though.

kennyadsl

Thanks @peterberkenbosch, does it work on Linux now?

jacobherrington

Sorry, I merged #3088 too fast 🔥 😅

fix sed call so it works on mac

8c1bd4f

before: ``` sed: 1: "Gemfile": extra characters at the end of G command ``` this commit tries to make it work on all systems. Might not work on Windows systems though.

kennyadsl approved these changes Feb 8, 2019

View reviewed changes

jacobherrington approved these changes Feb 8, 2019

View reviewed changes

jacobherrington merged commit 2364410 into solidusio:master Feb 10, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix sed call so it works on mac #3091

fix sed call so it works on mac #3091

peterberkenbosch commented Feb 8, 2019

kennyadsl left a comment

jacobherrington left a comment

fix sed call so it works on mac #3091

fix sed call so it works on mac #3091

Conversation

peterberkenbosch commented Feb 8, 2019

kennyadsl left a comment

Choose a reason for hiding this comment

jacobherrington left a comment

Choose a reason for hiding this comment