Add tests for locale switch on backend #3083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spaghetticode
approved these changes
Feb 7, 2019
There was a problem hiding this comment.
There's one check that looks stuck:In progress — started 17 hours ago
Anyway it looks good to me, @coorasse thanks for adding these valuable specs 👍
kennyadsl
reviewed
Feb 7, 2019
There was a problem hiding this comment.
Should you also change the commit message since this is no more fixing the bug but just adding a regression test around that?
On a side note, I know that @DanielePalombo found another existing test in our suite that was green even without the fix but I think this could be faced into another PR.
Keep quotes consistent
coorasse
force-pushed
the
fix_locale_setting
branch
from
0c12ac6
to
6dd4708
Compare
jacobherrington
approved these changes
Feb 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I noticed the locale switch was not working on the backend and it has been fixed correctly.
Tests where missing, so here they are.
Checklist: