Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testing tools improvements #3062

Merged
merged 7 commits into from
Jan 31, 2019
Merged

Testing tools improvements #3062

merged 7 commits into from
Jan 31, 2019

Conversation

kennyadsl
Copy link
Member

Description

This PR:

  • bumps Capybara to 3.x (we still are on 2.x), here's the upgrading guide
  • removes Poltergeist from Gemfile, which is not used anymore
  • switches Capybara server to Puma, to reflect the new standard in both Capybara and Rails. I don't think we'll have some real advantage using Puma over WEBRick, but this is the new standard and probably what all developers expect (I don't have strong opinions here).

Checklist:

  • Pull Request guidelines are respected
  • Documentation/Readme have been updated accordingly
  • Changes are covered by tests (if possible)
  • Each commit has a meaningful message attached that described WHAT changed, and WHY

@kennyadsl kennyadsl self-assigned this Jan 30, 2019
@kennyadsl
Implement a pending test on order details
a1ddb6c 
It tests that an alert is displayed in the browser to inform the
admin user that a destination stock location has to be selected.

This was not possible with poltergeist but we now only use selenium
with chrome headless.
@kennyadsl
Remove an hack in backend payment spec due to poltergeist
ce713bf 
It just use a simple fill_in now.
@kennyadsl
Remove poltergeist from Gemfile
4ff5eb7 
We are no loger using it and there's no need to keep that
dependency in our Gemfile.
@kennyadsl
Use Capybara 3
7e51306 
In Capybara 3 the deafult server is Puma, that we don't have (still?)
in Solidus. For now we can manually switch it back to Webrick.
@kennyadsl
Fix a Gemfile dependency format
23b8a95 
Just to have all items uniform
@kennyadsl
Fix specs that need whitespace normalization
21383ae 
With Capybara 3 texts are no more fully normalized but we have
specs when this is required since there are special chars into
the strings we are checking against.

More info here:
https://github.com/teamcapybara/capybara/blob/master/UPGRADING.md#node
@kennyadsl
Switch Capybara server to Puma
8e4bd69 
It is the default for Rails and for Capybara 3.x.
jacobherrington
jacobherrington approved these changes Jan 30, 2019
View reviewed changes
Copy link
Contributor

@jacobherrington jacobherrington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Woo!

@kennyadsl kennyadsl merged commit a7e2c6d into solidusio:master Jan 31, 2019
@kennyadsl kennyadsl deleted the kennyadsl/testing-tool-bump branch January 31, 2019 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aitbw aitbw aitbw left review comments

@gmacdougall gmacdougall gmacdougall approved these changes

@jacobherrington jacobherrington jacobherrington approved these changes

Assignees

@kennyadsl kennyadsl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kennyadsl @gmacdougall @aitbw @jacobherrington