Skip populating states select on default country not included in available countries #3030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Jan 9, 2019
mdesantis
changed the title
mdesantis
force-pushed
the
mdesantis/1025/skip-setting-default-state-on-invalid-country
branch
from
6743379
to
4ecb4cf
Compare
mdesantis
changed the title
mdesantis
changed the title
mdesantis
force-pushed
the
mdesantis/1025/skip-setting-default-state-on-invalid-country
branch
from
4ecb4cf
to
2c54f53
Compare
mdesantis
changed the title
mdesantis
force-pushed
the
mdesantis/1025/skip-setting-default-state-on-invalid-country
branch
from
2c54f53
to
9f1d5fb
Compare
houndci-bot
reviewed
Jan 9, 2019
mdesantis
force-pushed
the
mdesantis/1025/skip-setting-default-state-on-invalid-country
branch
3 times, most recently
from
de3934a
to
1bd4b36
Compare
Closes solidusio#1205. In the case that default country is not included within available countries, this commit leaves the states select empty, where previously was filled in with default country states which didn't match with any available country. The state select is later filled in by Select2, which knows which country option is selected. Server side we can't assume that the first country option is selected, because it doesn't play well with client side features, e.g. autocomplete.
mdesantis
force-pushed
the
mdesantis/1025/skip-setting-default-state-on-invalid-country
branch
from
1bd4b36
to
8814b86
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #1205. it:
country. The state select is later filled in by Select2, which knows which country option is selected. Server side we can't assume that the first country option is selected, because it doesn't play well with client side features, e.g. autocomplete.
Checklist: