Enable partial doubles verification for RSpec (part 2) #3015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Dec 31, 2018
frontend/spec/support/example_groups/partial_double_verification_example_group.rb
Outdated
Show resolved
Hide resolved
backend/spec/support/example_groups/partial_double_verification_example_group.rb
Outdated
Show resolved
Hide resolved
cedum
force-pushed
the
cedum/enable_verify_partial_doubles_p2
branch
from
f1413ef
to
92e82c3
Compare
kennyadsl
reviewed
Jan 2, 2019
| @@ -0,0 +1,16 @@ | |||
| # frozen_string_literal: true | |||
|
|
|||
| module PartialDoubleVerificationExampleGroup | |||
There was a problem hiding this comment.
Can't we share the support file introduced in core via #3005 ? Maybe moving the module in core/lib into the testing_support folder?
aitbw
approved these changes
Jan 9, 2019
There was a problem hiding this comment.
Other than @kennyadsl's comment to DRY this a little bit, LGTM! 💪
cedum
force-pushed
the
cedum/enable_verify_partial_doubles_p2
branch
from
92e82c3
to
0ec2707
Compare
Allow mocking of `LineItem` user provided attributes through the `options` parameter.
Allows mocking of URL helpers in the footer view tests.
When mocking an authenticated user in a Backend or Frontend controller, use the `try_spree_current_user` method, instead of `spree_current_user`.
Disables RSpec partial double verification for Frontend checkout specs depending on the Order state machine, which is not supported.
Mocking dynamically defined methods is not supported when having `verify_partial_doubles` enabled.
cedum
force-pushed
the
cedum/enable_verify_partial_doubles_p2
branch
from
0ec2707
to
ce85e17
Compare
|
Pushed some changes that DRYes the partial double verification support file as per @kennyadsl suggestion. |
jacobherrington
approved these changes
Jan 16, 2019
gmacdougall
approved these changes
Jan 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up of #3005 and enables the partial double verification for RSpec also in Solidus API, Frontend and Backend.