Prevent multiple refund creations with accidental double clicks #2970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spaghetticode
force-pushed
the
refund-button-disable-on-submit
branch
from
7a7f6a7
to
660d1b6
Compare
The submit button must be disabled after submit or accidental double clicks could generate multiple refunds. While successful refund creation with fast multiple clicks cannot be tested with Selenium, a spec that shows how button is disabled after submit has been added.
spaghetticode
force-pushed
the
refund-button-disable-on-submit
branch
from
660d1b6
to
a48ad86
Compare
elia
approved these changes
Nov 23, 2018
jacobherrington
approved these changes
Nov 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating refunds, if the admin user accidentally clicks multiple times on the submit button then multiple refunds may be created.
This PR avoids the issue by disabling the button after click.