Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable 'count on hand' input when 'track inventory' option is set to false #2960

Merged

Conversation

aitbw
Copy link
Contributor

@aitbw aitbw commented Nov 20, 2018

This patch aims to fix #2946 by disabling the Count on hand input when the Track inventory option/attribute is set to false.

Here's an screenshot for demonstration purposes:

screenshot_2018-11-20 store stock - apache baseball jersey - products

It also includes a tooltip to help users understand why said input is disabled.

Open to suggestions!

Copy link
Contributor

@ericsaupe ericsaupe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me.

Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Contributor

@jacobherrington jacobherrington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Misleading notification when updating stock for a variant that is not tracking inventory
4 participants